Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exclude votes without proposals #921

Merged
merged 1 commit into from
Sep 8, 2024
Merged

fix: Exclude votes without proposals #921

merged 1 commit into from
Sep 8, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Sep 7, 2024

Temporary fix for #760

How to test:

  • Test with:
query Votes {
    votes(first: 1000, where: { voter: "0x24F15402C6Bb870554489b2fd2049A85d75B982f" }) {
     id  
    proposal {
        id
        space {
          id
        }
        ipfs
      }
    }
  }

Should return values without null in proposal

query { 
  vote(id: "0xd954ffa9c8766c7f1195f867522ac759d8f752781d811941c91e289032e7df90") {
    
    id
    proposal {
      id
    }
  }
}

Should return null

@ChaituVR ChaituVR requested a review from wa0x6e September 7, 2024 17:26
wa0x6e
wa0x6e approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit e24993c into master Sep 8, 2024
2 checks passed
@ChaituVR ChaituVR deleted the fix-votes-without-proposal branch September 8, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e